Skip to content

Commit 12936ff

Browse files
committed
Java: Fix IncorrectSerializableMethods.ql using wrong readObject signature
1 parent b009886 commit 12936ff

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

java/ql/src/Likely Bugs/Serialization/IncorrectSerializableMethods.ql

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@ import java
1616
from Method m, TypeSerializable serializable
1717
where
1818
m.getDeclaringType().hasSupertype+(serializable) and
19-
m.getNumberOfParameters() = 1 and
20-
m.getAParameter().getType().(RefType).hasQualifiedName("java.io", "ObjectOutputStream") and
21-
(m.hasName("readObject") or m.hasName("writeObject")) and
19+
(
20+
m.hasStringSignature("readObject(ObjectInputStream)") or
21+
m.hasName("writeObject(ObjectOutputStream)")
22+
) and
2223
not m.isPrivate()
2324
select m, "readObject and writeObject should be private methods."

0 commit comments

Comments
 (0)