Skip to content

Commit 14a31a2

Browse files
authored
Merge pull request github#6732 from RasmusWL/minor-sqlalchemy-comment-fixes
2 parents a66f836 + 8badba2 commit 14a31a2

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

python/ql/lib/semmle/python/frameworks/SqlAlchemy.qll

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,10 +300,9 @@ module SqlAlchemy {
300300
* there are many many constructs we would need to have models for. (see the 2
301301
* examples below)
302302
*
303-
* So instead we flag user-input to a TextClause with its' own query
304-
* (`py/sqlalchemy-textclause-injection`). And so we don't highlight any parts of an
305-
* ORM constructed query such as these as containing SQL, and don't need the additional
306-
* taint steps either.
303+
* So instead we extended the SQL injection query to include TextClause construction
304+
* as a sink. And so we don't highlight any parts of an ORM constructed query such as
305+
* these as containing SQL, and don't need the additional taint steps either.
307306
*
308307
* See
309308
* - https://docs.sqlalchemy.org/en/14/core/sqlelement.html#sqlalchemy.sql.expression.TextClause.

python/ql/test/library-tests/frameworks/sqlalchemy/new_tests.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,8 @@ class For14(Base):
202202
# - This would require a LOT of modeling for these additional taint steps, since there
203203
# are many many constructs we would need to have models for. (see the 2 examples below)
204204
#
205-
# So instead we flag user-input to a TextClause with its' own query. And so we don't
206-
# highlight any parts of an ORM constructed query such as these as containing SQL.
205+
# So instead we extended the SQL injection query to include TextClause construction as a
206+
# sink directly.
207207

208208
# `filter` provides more general filtering
209209
# see https://docs.sqlalchemy.org/en/14/orm/tutorial.html#common-filter-operators

0 commit comments

Comments
 (0)