File tree Expand file tree Collapse file tree 2 files changed +5
-6
lines changed
lib/semmle/python/frameworks
test/library-tests/frameworks/sqlalchemy Expand file tree Collapse file tree 2 files changed +5
-6
lines changed Original file line number Diff line number Diff line change @@ -300,10 +300,9 @@ module SqlAlchemy {
300
300
* there are many many constructs we would need to have models for. (see the 2
301
301
* examples below)
302
302
*
303
- * So instead we flag user-input to a TextClause with its' own query
304
- * (`py/sqlalchemy-textclause-injection`). And so we don't highlight any parts of an
305
- * ORM constructed query such as these as containing SQL, and don't need the additional
306
- * taint steps either.
303
+ * So instead we extended the SQL injection query to include TextClause construction
304
+ * as a sink. And so we don't highlight any parts of an ORM constructed query such as
305
+ * these as containing SQL, and don't need the additional taint steps either.
307
306
*
308
307
* See
309
308
* - https://docs.sqlalchemy.org/en/14/core/sqlelement.html#sqlalchemy.sql.expression.TextClause.
Original file line number Diff line number Diff line change @@ -202,8 +202,8 @@ class For14(Base):
202
202
# - This would require a LOT of modeling for these additional taint steps, since there
203
203
# are many many constructs we would need to have models for. (see the 2 examples below)
204
204
#
205
- # So instead we flag user-input to a TextClause with its' own query. And so we don't
206
- # highlight any parts of an ORM constructed query such as these as containing SQL .
205
+ # So instead we extended the SQL injection query to include TextClause construction as a
206
+ # sink directly .
207
207
208
208
# `filter` provides more general filtering
209
209
# see https://docs.sqlalchemy.org/en/14/orm/tutorial.html#common-filter-operators
You can’t perform that action at this time.
0 commit comments