Skip to content

Commit 1c5d59f

Browse files
committed
fix an instance of ql/acronyms-should-be-pascal-case
1 parent ea6b68f commit 1c5d59f

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

javascript/ql/lib/semmle/javascript/security/dataflow/DomBasedXssCustomizations.qll

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,13 @@ module DomBasedXss {
116116
/**
117117
* A write to a URL which may execute JavaScript code.
118118
*/
119-
class WriteURLSink extends Sink instanceof ClientSideUrlRedirect::Sink {
120-
WriteURLSink() { super.isXssSink() }
119+
class WriteUrlSink extends Sink instanceof ClientSideUrlRedirect::Sink {
120+
WriteUrlSink() { super.isXssSink() }
121121
}
122122

123+
/** DEPRECATED: Alias for `WriteUrlSink`. */
124+
deprecated class WriteURLSink = WriteUrlSink;
125+
123126
/**
124127
* An expression whose value is interpreted as HTML or CSS
125128
* and may be inserted into the DOM.

javascript/ql/lib/semmle/javascript/security/dataflow/DomBasedXssQuery.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ deprecated class JQueryHtmlOrSelectorInjectionConfiguration = Configuration;
2525
*/
2626
class HTMLSink extends DataFlow::Node instanceof Sink {
2727
HTMLSink() {
28-
not this instanceof WriteURLSink and
28+
not this instanceof WriteUrlSink and
2929
not this instanceof JQueryHtmlOrSelectorSink
3030
}
3131
}
@@ -61,7 +61,7 @@ class Configuration extends TaintTracking::Configuration {
6161
sink instanceof JQueryHtmlOrSelectorSink and
6262
label = [DataFlow::FlowLabel::taint(), prefixLabel()]
6363
or
64-
sink instanceof WriteURLSink and
64+
sink instanceof WriteUrlSink and
6565
label = prefixLabel()
6666
}
6767

javascript/ql/lib/semmle/javascript/security/dataflow/XssThroughDomQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class Configuration extends TaintTracking::Configuration {
4646
super.hasFlowPath(src, sink) and
4747
// filtering away readings of `src` that end in a URL sink.
4848
not (
49-
sink.getNode() instanceof DomBasedXss::WriteURLSink and
49+
sink.getNode() instanceof DomBasedXss::WriteUrlSink and
5050
src.getNode().(DomPropertySource).getPropertyName() = "src"
5151
)
5252
}

0 commit comments

Comments
 (0)