Apply suggestions from code review

hvitved · aschackmull · web-flow · commit 296e268339df · 2021-10-12T14:28:32.000+02:00
Co-authored-by: Anders Schack-Mulligen &lt;aschackmull@users.noreply.github.com&gt;
diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
@@ -958,7 +958,6 @@ module Private {
 
     query predicate edges(NodeOrCall a, NodeOrCall b, string key, string value) {
       key = "semmle.label" and
-      edgesComponent(a, b, _) and
       value = strictconcat(string s | edgesComponent(a, b, s) | s, " / ")
     }
   }
diff --git a/java/ql/test/library-tests/dataflow/callback-dispatch/A.java b/java/ql/test/library-tests/dataflow/callback-dispatch/A.java
@@ -179,7 +179,7 @@ static void applyConsumer1Field1Field2(A a1, A a2, Consumer1 con) {
 
   void foo3() {
     A a1 = new A();
-    a1.field1 = source(1);
+    a1.field1 = source(20);
     A a2 = new A();
     applyConsumer1Field1Field2(a1, a2, p -> {
       sink(p); // MISSING FLOW

Original file line number	Diff line number	Diff line change
`@@ -958,7 +958,6 @@ module Private {`
`958`	`958`
`959`	`959`	`query predicate edges(NodeOrCall a, NodeOrCall b, string key, string value) {`
`960`	`960`	`key = "semmle.label" and`
`961`		`- edgesComponent(a, b, _) and`
`962`	`961`	`value = strictconcat(string s \| edgesComponent(a, b, s) \| s, " / ")`
`963`	`962`	`}`
`964`	`963`	`}`