Skip to content

Commit 2ad4921

Browse files
RasmusWLasgerf
andauthored
Ruby: Apply suggestions from code review
Co-authored-by: Asger F <[email protected]>
1 parent bb0435a commit 2ad4921

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

ruby/ql/lib/codeql/ruby/ApiGraphs.qll

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,10 @@ module API {
793793
or
794794
pos.isAnyNamed() and
795795
result = Label::keywordParameter(_)
796-
// TODO: needs handling of `self` ArgumentPosition
796+
// Note: there is currently no API graph label for `self`.
797+
// It was omitted since in practice it means going back to where you came from.
798+
// For example, `base.getMethod("foo").getSelf()` would just be `base`.
799+
// However, it's possible we'll need it later, for identifying `self` parameters or post-update nodes.
797800
// or
798801
// pos.isSelf() and
799802
// ...

0 commit comments

Comments
 (0)