Skip to content

Commit 3504408

Browse files
jorgectfRasmusWL
andauthored
Apply suggestions from code review
Update `xmltodict` format and delete `ujson` modeling. Co-authored-by: Rasmus Wriedt Larsen <[email protected]>
1 parent 68c6831 commit 3504408

File tree

1 file changed

+1
-23
lines changed
  • python/ql/src/experimental/semmle/python/frameworks

1 file changed

+1
-23
lines changed

python/ql/src/experimental/semmle/python/frameworks/Stdlib.qll

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -119,27 +119,5 @@ private class XmlToDictParseCall extends Decoding::Range, DataFlow::CallCfgNode
119119

120120
override DataFlow::Node getOutput() { result = this }
121121

122-
override string getFormat() { result = "JSON" }
123-
}
124-
125-
// ---------------------------------------------------------------------------
126-
// ujson
127-
// ---------------------------------------------------------------------------
128-
/** Gets a reference to the `ujson` module. */
129-
API::Node ujson() { result = API::moduleImport("ujson") }
130-
131-
/**
132-
* A call to `ujson.loads`
133-
* See https://pypi.org/project/ujson/#usage
134-
*/
135-
private class UltraJsonLoadsCall extends Decoding::Range, DataFlow::CallCfgNode {
136-
UltraJsonLoadsCall() { this = ujson().getMember("loads").getACall() }
137-
138-
override predicate mayExecuteInput() { none() }
139-
140-
override DataFlow::Node getAnInput() { result = this.getArg(0) }
141-
142-
override DataFlow::Node getOutput() { result = this }
143-
144-
override string getFormat() { result = "JSON" }
122+
override string getFormat() { result = "XML" }
145123
}

0 commit comments

Comments
 (0)