Skip to content

Commit 405480c

Browse files
committed
Python: Rename sink definitions for XXE/XML bomb
1 parent 7728b6c commit 405480c

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

python/ql/src/experimental/semmle/python/security/dataflow/XmlBombCustomizations.qll

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,10 @@ module XmlBomb {
3535
}
3636

3737
/**
38-
* A call to an XML parser that performs internal entity expansion, viewed
39-
* as a data flow sink for XML-bomb vulnerabilities.
38+
* A call to an XML parser that is vulnerable to XML bombs.
4039
*/
41-
class XmlParsingWithEntityResolution extends Sink {
42-
XmlParsingWithEntityResolution() {
40+
class XmlParsingVulnerableToXmlBomb extends Sink {
41+
XmlParsingVulnerableToXmlBomb() {
4342
exists(XML::XmlParsing parsing, XML::XmlParsingVulnerabilityKind kind |
4443
kind.isXmlBomb() and
4544
parsing.vulnerableTo(kind) and

python/ql/src/experimental/semmle/python/security/dataflow/XxeCustomizations.qll

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,10 @@ module Xxe {
3535
}
3636

3737
/**
38-
* A call to an XML parser that performs external entity expansion, viewed
39-
* as a data flow sink for XXE vulnerabilities.
38+
* A call to an XML parser that is vulnerable to XXE.
4039
*/
41-
class XmlParsingWithExternalEntityResolution extends Sink {
42-
XmlParsingWithExternalEntityResolution() {
40+
class XmlParsingVulnerableToXxe extends Sink {
41+
XmlParsingVulnerableToXxe() {
4342
exists(XML::XmlParsing parsing, XML::XmlParsingVulnerabilityKind kind |
4443
kind.isXxe() and
4544
parsing.vulnerableTo(kind) and

0 commit comments

Comments
 (0)