Simplify specifiesContentType predicate

smowton · smowton · commit 406466de9a98 · 2021-09-14T15:24:46.000+01:00
diff --git a/java/ql/lib/semmle/code/java/frameworks/spring/SpringHttp.qll b/java/ql/lib/semmle/code/java/frameworks/spring/SpringHttp.qll
@@ -145,8 +145,7 @@ private class SpringHttpFlowStep extends SummaryModelCsv {
 }
 
 private predicate specifiesContentType(SpringRequestMappingMethod method) {
-  method.getProducesExpr().(ArrayInit).getSize() != 0 or
-  not method.getProducesExpr() instanceof ArrayInit
+  exists(method.getAProducesExpr())
 }
 
 private class SpringXssSink extends XSS::XssSink {

Original file line number	Diff line number	Diff line change
`@@ -145,8 +145,7 @@ private class SpringHttpFlowStep extends SummaryModelCsv {`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`private predicate specifiesContentType(SpringRequestMappingMethod method) {`
`148`		`- method.getProducesExpr().(ArrayInit).getSize() != 0 or`
`149`		`- not method.getProducesExpr() instanceof ArrayInit`
	`148`	`+ exists(method.getAProducesExpr())`
`150`	`149`	`}`
`151`	`150`
`152`	`151`	`private class SpringXssSink extends XSS::XssSink {`