Skip to content

Commit 434a2a9

Browse files
committed
Improve qhelp example text
1 parent c909b88 commit 434a2a9

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

java/ql/src/Security/CWE/CWE-441/UnsafeContentUriResolution.qhelp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,11 @@
2929
</recommendation>
3030
<example>
3131
<p>
32-
This example shows two ways of opening a file using a <code>ContentResolver</code>. In the first case, externally-provided
32+
This example shows three ways of opening a file using a <code>ContentResolver</code>. In the first case, externally-provided
3333
data from an intent is used directly in the file-reading operation. This allows an attacker to provide a URI
3434
of the form <code>/data/data/(vulnerable app package)/(private file)</code> to trick the application into reading it and
35-
copying it to the external storage. In the second case, the URI is validated before being used, making sure it does not reference
35+
copying it to the external storage. In the second case, an insufficient check is performed on the externally-provided URI, still
36+
leaving room for exploitation. In the third case, the URI is correctly validated before being used, making sure it does not reference
3637
any internal application files.
3738
</p>
3839
<sample src="UnsafeContentUriResolution.java" />

0 commit comments

Comments
 (0)