Cache hasLocalSource

hvitved · hvitved · commit 45412fa17f94 · 2022-02-08T13:03:27.000+01:00
diff --git a/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPublic.qll b/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPublic.qll
@@ -121,7 +121,8 @@ class LocalSourceNode extends Node {
   LocalSourceNode backtrack(TypeBackTracker t2, TypeBackTracker t) { t2 = t.step(result, this) }
 }
 
-predicate hasLocalSource(Node sink, Node source) {
+cached
+private predicate hasLocalSource(Node sink, Node source) {
   // Declaring `source` to be a `SourceNode` currently causes a redundant check in the
   // recursive case, so instead we check it explicitly here.
   source = sink and

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,8 @@ class LocalSourceNode extends Node {`
`121`	`121`	`LocalSourceNode backtrack(TypeBackTracker t2, TypeBackTracker t) { t2 = t.step(result, this) }`
`122`	`122`	`}`
`123`	`123`
`124`		`-predicate hasLocalSource(Node sink, Node source) {`
	`124`	`+cached`
	`125`	`+private predicate hasLocalSource(Node sink, Node source) {`
`125`	`126`	// Declaring `source` to be a `SourceNode` currently causes a redundant check in the
`126`	`127`	`// recursive case, so instead we check it explicitly here.`
`127`	`128`	`source = sink and`