Skip to content

Commit 4b198f9

Browse files
author
Alvaro Muñoz
committed
apply code review feedback
1 parent 844193d commit 4b198f9

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

go/ql/lib/semmle/go/frameworks/Twirp.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ module Twirp {
124124
ServerConstructor() {
125125
exists(ServiceServerType c, ServiceInterfaceType i |
126126
this.getName().toLowerCase() = "new" + c.getName().toLowerCase() and
127-
this.getParameter(0).getType() = i.getNamedType() and
127+
this.getParameterType(0) = i.getNamedType() and
128128
this.getDeclaration().getLocation().getFile() instanceof ServicesGeneratedFile
129129
)
130130
}

go/ql/test/library-tests/semmle/go/frameworks/Twirp/tests.expected

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ passingPositiveTests
22
| PASSED | clientConstructor | rpc/notes/service.twirp.go:53:114:53:139 | comment |
33
| PASSED | clientConstructor | rpc/notes/service.twirp.go:192:110:192:135 | comment |
44
| PASSED | message | rpc/notes/service.pb.go:23:20:23:35 | comment |
5-
| PASSED | message | rpc/notes/service.pb.go:86:32:86:49 | comment |
6-
| PASSED | message | rpc/notes/service.pb.go:133:33:133:50 | comment |
7-
| PASSED | message | rpc/notes/service.pb.go:171:33:171:50 | comment |
5+
| PASSED | message | rpc/notes/service.pb.go:86:32:86:47 | comment |
6+
| PASSED | message | rpc/notes/service.pb.go:133:33:133:48 | comment |
7+
| PASSED | message | rpc/notes/service.pb.go:171:33:171:48 | comment |
88
| PASSED | request | server/main.go:19:111:19:140 | comment |
99
| PASSED | request | server/main.go:40:126:40:155 | comment |
1010
| PASSED | serverConstructor | rpc/notes/service.twirp.go:334:81:334:106 | comment |

0 commit comments

Comments
 (0)