Merge pull request github#12875 from kaspersv/kaspersv/prevent-ruby-join-order-regression

Prevent Ruby join order regression

Author: kaspersv

ruby/ql/lib/codeql/ruby/ast/internal/Synthesis.qll

@@ -1169,12 +1169,11 @@ private module ArrayLiteralDesugar {
       child = SynthChild(MethodCallKind("[]", false, al.getNumberOfElements()))
       or
       parent = TMethodCallSynth(al, -1, _, _, _) and
-      (
-        i = 0 and
-        child = SynthChild(ConstantReadAccessKind("::Array"))
-        or
-        child = childRef(al.getElement(i - 1))
-      )
+      i = 0 and
+      child = SynthChild(ConstantReadAccessKind("::Array"))
+      or
+      parent = TMethodCallSynth(al, -1, _, _, _) and
+      child = childRef(al.getElement(i - 1))
     )
   }