Skip to content

Commit 51f9314

Browse files
committed
Kotlin: Consider ::class type check in equals
1 parent f7f1207 commit 51f9314

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ predicate hasTypeTest(Variable v) {
3030
or
3131
any(SafeCastExpr sce).getExpr() = v.getAnAccess()
3232
or
33+
any(ClassExpr c).getExpr() = v.getAnAccess()
34+
or
3335
exists(MethodAccess ma |
3436
ma.getMethod().getName() = "getClass" and
3537
ma.getQualifier() = v.getAnAccess()
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +0,0 @@
1-
| Test.kt:10:14:12:5 | equals | This 'equals()' method does not check argument type. |

0 commit comments

Comments
 (0)