Skip to content

Commit 523ddb7

Browse files
committed
Cleanup after code review feedback
1 parent 5243fe3 commit 523ddb7

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

java/ql/lib/semmle/code/java/frameworks/Properties.qll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
import semmle.code.java.Type
33
private import semmle.code.java.dataflow.FlowSteps
44

5-
library class TypeProperty extends Class {
5+
class TypeProperty extends Class {
66
TypeProperty() { hasQualifiedName("java.util", "Properties") }
77
}
88

9-
library class PropertiesGetPropertyMethod extends ValuePreservingMethod {
9+
class PropertiesGetPropertyMethod extends ValuePreservingMethod {
1010
PropertiesGetPropertyMethod() {
1111
getDeclaringType() instanceof TypeProperty and
1212
hasName("getProperty")
@@ -15,21 +15,21 @@ library class PropertiesGetPropertyMethod extends ValuePreservingMethod {
1515
override predicate returnsValue(int arg) { arg = 1 }
1616
}
1717

18-
library class PropertiesGetMethod extends Method {
18+
class PropertiesGetMethod extends Method {
1919
PropertiesGetMethod() {
2020
getDeclaringType() instanceof TypeProperty and
2121
hasName("get")
2222
}
2323
}
2424

25-
library class PropertiesSetPropertyMethod extends Method {
25+
class PropertiesSetPropertyMethod extends Method {
2626
PropertiesSetPropertyMethod() {
2727
getDeclaringType() instanceof TypeProperty and
2828
hasName("setProperty")
2929
}
3030
}
3131

32-
library class PropertiesStoreMethod extends Method {
32+
class PropertiesStoreMethod extends Method {
3333
PropertiesStoreMethod() {
3434
getDeclaringType() instanceof TypeProperty and
3535
(getName().matches("store%") or getName() = "save")

java/ql/src/change-notes/2022-02-14-os-guards.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ category: minorAnalysis
44
* Add new guards `IsWindowsGuard`, `IsSpecificWindowsVariant`, `IsUnixGuard`, and `IsSpecificUnixVariant` to detect OS specific guards.
55
* Add new predicate `getSystemProperty` that gets all expressions that retrieve system properties from a variety of sources (eg. alternative JDK API's, Google Guava, Apache Commons, Apache IO, ect..).
66
* Update "Local information disclosure in a temporary directory" (`java/local-temp-file-or-directory-information-disclosure`) to remove false-positives when OS is properly used as logical guard.
7-
* Update "Local information disclosure in a temporary directory" (`java/local-temp-file-or-directory-information-disclosure`) to use `getSystemProperty` to resolve more
7+
* Update "Local information disclosure in a temporary directory" (`java/local-temp-file-or-directory-information-disclosure`) to use `getSystemProperty` to use new `getSystemProperty` predicate.
88

0 commit comments

Comments
 (0)