Swift: Remove TODO comment. We have a test for this problem now.

geoffw0 · geoffw0 · commit 541df9b5505e · 2022-07-18T14:26:12.000+01:00
diff --git a/swift/ql/src/queries/Security/CWE-135/StringLengthConflation.ql b/swift/ql/src/queries/Security/CWE-135/StringLengthConflation.ql
@@ -74,7 +74,7 @@ class StringLengthConflationConfiguration extends DataFlow::Configuration {
             paramName = "at"
           ) and
           c.getName() = className and
-          c.getAMember() = funcDecl and // TODO: will this even work if its defined in a parent class?
+          c.getAMember() = funcDecl and
           call.getFunction().(ApplyExpr).getStaticTarget() = funcDecl and
           flowstate = "String" // `String` length flowing into `NSString`
         )

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ class StringLengthConflationConfiguration extends DataFlow::Configuration {`
`74`	`74`	`paramName = "at"`
`75`	`75`	`) and`
`76`	`76`	`c.getName() = className and`
`77`		`- c.getAMember() = funcDecl and // TODO: will this even work if its defined in a parent class?`
	`77`	`+ c.getAMember() = funcDecl and`
`78`	`78`	`call.getFunction().(ApplyExpr).getStaticTarget() = funcDecl and`
`79`	`79`	flowstate = "String" // `String` length flowing into `NSString`
`80`	`80`	`)`