Skip to content

Commit 55e78e3

Browse files
joefarebrotheratorralba
authored andcommitted
Minor doc fixes + making directFileRead private
1 parent a41f28e commit 55e78e3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

java/ql/lib/semmle/code/java/frameworks/android/ExternalStorage.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ private predicate externalStorageFlow(DataFlow::Node node1, DataFlow::Node node2
3939

4040
/**
4141
* Holds if `n` is a node that reads the contents of an external file in Android.
42-
* This is controlable by third-party applications, so is treated as a remote flow source.
42+
* This is controllable by third-party applications, so is treated as a remote flow source.
4343
*/
4444
predicate androidExternalStorageSource(DataFlow::Node n) {
4545
exists(DataFlow::Node externalDir, DirectFileReadExpr read |

java/ql/lib/semmle/code/java/security/FileReadWrite.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import java
33
/**
44
* Holds if `fileAccess` is directly used in the `fileReadingExpr` to read the represented file.
55
*/
6-
predicate directFileRead(Expr fileAccess, Expr fileReadingExpr) {
6+
private predicate directFileRead(Expr fileAccess, Expr fileReadingExpr) {
77
// `fileAccess` used to construct a class that reads a file.
88
exists(ClassInstanceExpr cie |
99
cie = fileReadingExpr and
@@ -64,7 +64,7 @@ class DirectFileReadExpr extends Expr {
6464
DirectFileReadExpr() { directFileRead(_, this) }
6565

6666
/**
67-
* Gets the `Expr` representing the file that is read
67+
* Gets the `Expr` representing the file that is read.
6868
*/
6969
Expr getFileExpr() { directFileRead(result, this) }
7070
}

0 commit comments

Comments
 (0)