Skip to content

Commit 56797c5

Browse files
authored
Merge pull request github#10776 from tamasvajk/kotlin-missing-override-fix
Kotlin/Java: Exclude generated code from `java/missing-override-annotation`
2 parents 3910704 + 9b2cc6c commit 56797c5

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

java/ql/src/Advisory/Declarations/MissingOverrideAnnotation.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ where
2323
m.overrides(overridden) and
2424
not m.hasModifier("override") and
2525
not m.isOverrideAnnotated() and
26-
not exists(FunctionalExpr mref | mref.asMethod() = m)
26+
not exists(FunctionalExpr mref | mref.asMethod() = m) and
27+
// Ignore generated constructs, such as <clinit> functions extracted from Kotlin code:
28+
not m.isCompilerGenerated()
2729
select m, "This method overrides $@; it is advisable to add an Override annotation.", overridden,
2830
overridden.getDeclaringType() + "." + overridden.getName()

0 commit comments

Comments
 (0)