Skip to content

Commit 58a0bcd

Browse files
atorralbasmowton
andcommitted
Apply suggestions from code review
Co-authored-by: Chris Smowton <[email protected]>
1 parent 8767d2d commit 58a0bcd

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

java/ql/lib/semmle/code/java/security/IntentUriPermissionManipulation.qll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ private class IntentFlagsOrDataCheckedGuard extends IntentUriPermissionManipulat
7272

7373
override predicate checks(Expr e, boolean branch) {
7474
exists(MethodAccess ma, Method m |
75+
// This checks `intent` when the result of an `intent.getFlags` or `intent.getData` call flows to `condition`
76+
// (i.e., that result is equality-tested)
7577
ma.getMethod() = m and
7678
m.getDeclaringType() instanceof TypeIntent and
7779
m.hasName(["getFlags", "getData"]) and

0 commit comments

Comments
 (0)