Merge pull request github#10786 from github/alexdenisov/xcode-autobuilder

Swift: introduce Xcode autobuilder

Author: AlexDenisov

swift/BUILD.bazel

@@ -24,8 +24,8 @@ pkg_files(
 )
 
 pkg_files(
-    name = "qltest",
-    srcs = ["tools/qltest.sh"],
+    name = "scripts",
+    srcs = ["tools/qltest.sh", "tools/autobuild.sh"],
     attributes = pkg_attributes(mode = "0755"),
     prefix = "tools",
 )
@@ -46,8 +46,8 @@ pkg_filegroup(
     srcs = [
         ":dbscheme_files",
         ":manifest",
-        ":qltest",
         ":tracing-config",
+        ":scripts",
     ],
     visibility = ["//visibility:public"],
 )
@@ -58,6 +58,12 @@ pkg_runfiles(
     prefix = "tools/" + codeql_platform,
 )
 
+pkg_runfiles(
+    name = "xcode-autobuilder",
+    srcs = ["//swift/xcode-autobuilder"],
+    prefix = "tools/" + codeql_platform,
+)
+
 pkg_files(
     name = "swift-test-sdk-arch",
     srcs = ["//swift/tools/prebuilt:swift-test-sdk"],
@@ -70,7 +76,12 @@ pkg_filegroup(
     srcs = [
         ":extractor",
         ":swift-test-sdk-arch",
-    ],
+    ] + select({
+        "@platforms//os:linux": [],
+        "@platforms//os:macos": [
+            ":xcode-autobuilder"
+        ],
+    }),
     visibility = ["//visibility:public"],
 )
 

swift/CMakeLists.txt

@@ -14,3 +14,4 @@ project(codeql)
 include(../misc/bazel/cmake/setup.cmake)
 
 include_generated(//swift/extractor:cmake)
+include_generated(//swift/xcode-autobuilder:cmake)

swift/tools/autobuild.sh

@@ -0,0 +1,8 @@
+#!/bin/bash
+
+if [[ "$OSTYPE" == "darwin"* ]]; then
+  exec "${CODEQL_EXTRACTOR_SWIFT_ROOT}/tools/${CODEQL_PLATFORM}/xcode-autobuilder"
+else
+  echo "Not implemented yet"
+  exit 1
+fi

swift/xcode-autobuilder/BUILD.bazel

@@ -0,0 +1,22 @@
+load("//swift:rules.bzl", "swift_cc_binary")
+load("//misc/bazel/cmake:cmake.bzl", "generate_cmake")
+
+swift_cc_binary(
+    name = "xcode-autobuilder",
+    srcs = glob([
+        "*.cpp",
+        "*.h",
+    ]),
+    visibility = ["//swift:__pkg__"],
+    linkopts = [
+        "-lxml2",
+        "-framework CoreFoundation",
+    ],
+    target_compatible_with = ["@platforms//os:macos"],
+)
+
+generate_cmake(
+    name = "cmake",
+    targets = [":xcode-autobuilder"],
+    visibility = ["//visibility:public"],
+)

swift/xcode-autobuilder/CFHelpers.cpp

@@ -0,0 +1,41 @@
+#include "swift/xcode-autobuilder/CFHelpers.h"
+
+#include <iostream>
+
+typedef CFTypeID (*cf_get_type_id)();
+
+template <typename CFType, cf_get_type_id get_type_id>
+CFType cf_cast(const void* ptr) {
+  if (!ptr) {
+    return nullptr;
+  }
+  if (CFGetTypeID(ptr) != get_type_id()) {
+    std::cerr << "Unexpected type: ";
+    CFShow(ptr);
+    abort();
+  }
+  return static_cast<CFType>(ptr);
+}
+
+CFStringRef cf_string_ref(const void* ptr) {
+  return cf_cast<CFStringRef, CFStringGetTypeID>(ptr);
+}
+
+CFArrayRef cf_array_ref(const void* ptr) {
+  return cf_cast<CFArrayRef, CFArrayGetTypeID>(ptr);
+}
+CFDictionaryRef cf_dictionary_ref(const void* ptr) {
+  return cf_cast<CFDictionaryRef, CFDictionaryGetTypeID>(ptr);
+}
+
+std::string stringValueForKey(CFDictionaryRef dict, CFStringRef key) {
+  auto cfValue = cf_string_ref(CFDictionaryGetValue(dict, key));
+  if (cfValue) {
+    const int bufferSize = 256;
+    char buf[bufferSize];
+    if (CFStringGetCString(cfValue, buf, bufferSize, kCFStringEncodingUTF8)) {
+      return {buf};
+    }
+  }
+  return {};
+}

swift/xcode-autobuilder/CFHelpers.h

@@ -0,0 +1,24 @@
+#pragma once
+
+#include <CoreFoundation/CoreFoundation.h>
+#include <string>
+#include <vector>
+
+CFStringRef cf_string_ref(const void* ptr);
+CFArrayRef cf_array_ref(const void* ptr);
+CFDictionaryRef cf_dictionary_ref(const void* ptr);
+
+std::string stringValueForKey(CFDictionaryRef dict, CFStringRef key);
+
+struct CFKeyValues {
+  static CFKeyValues fromDictionary(CFDictionaryRef dict) {
+    auto size = CFDictionaryGetCount(dict);
+    CFKeyValues ret(size);
+    CFDictionaryGetKeysAndValues(dict, ret.keys.data(), ret.values.data());
+    return ret;
+  }
+  explicit CFKeyValues(size_t size) : size(size), keys(size), values(size) {}
+  size_t size;
+  std::vector<const void*> keys;
+  std::vector<const void*> values;
+};

swift/xcode-autobuilder/XcodeBuildRunner.cpp

@@ -0,0 +1,65 @@
+#include "swift/xcode-autobuilder/XcodeBuildRunner.h"
+
+#include <vector>
+#include <iostream>
+#include <spawn.h>
+
+static int waitpid_status(pid_t child) {
+  int status;
+  while (waitpid(child, &status, 0) == -1) {
+    if (errno != EINTR) break;
+  }
+  return status;
+}
+
+extern char** environ;
+
+static bool exec(const std::vector<std::string>& argv) {
+  const char** c_argv = (const char**)calloc(argv.size() + 1, sizeof(char*));
+  for (size_t i = 0; i < argv.size(); i++) {
+    c_argv[i] = argv[i].c_str();
+  }
+  c_argv[argv.size()] = nullptr;
+
+  pid_t pid = 0;
+  if (posix_spawn(&pid, argv.front().c_str(), nullptr, nullptr, (char* const*)c_argv, environ) !=
+      0) {
+    std::cerr << "[xcode autobuilder] posix_spawn failed: " << strerror(errno) << "\n";
+    free(c_argv);
+    return false;
+  }
+  free(c_argv);
+  int status = waitpid_status(pid);
+  if (!WIFEXITED(status) || WEXITSTATUS(status) != 0) {
+    return false;
+  }
+  return true;
+}
+
+void buildTarget(Target& target, bool dryRun) {
+  std::vector<std::string> argv({"/usr/bin/xcodebuild", "build"});
+  if (!target.workspace.empty()) {
+    argv.push_back("-workspace");
+    argv.push_back(target.workspace);
+    argv.push_back("-scheme");
+  } else {
+    argv.push_back("-project");
+    argv.push_back(target.project);
+    argv.push_back("-target");
+  }
+  argv.push_back(target.name);
+  argv.push_back("CODE_SIGNING_REQUIRED=NO");
+  argv.push_back("CODE_SIGNING_ALLOWED=NO");
+
+  if (dryRun) {
+    for (auto& arg : argv) {
+      std::cout << arg + " ";
+    }
+    std::cout << "\n";
+  } else {
+    if (!exec(argv)) {
+      std::cerr << "Build failed\n";
+      exit(1);
+    }
+  }
+}

swift/xcode-autobuilder/XcodeBuildRunner.h

@@ -0,0 +1,5 @@
+#pragma once
+
+#include "swift/xcode-autobuilder/XcodeTarget.h"
+
+void buildTarget(Target& target, bool dryRun);