Skip to content

Commit 6229112

Browse files
authored
remove constraint for Zip::File.open
1 parent 3c62271 commit 6229112

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

ruby/ql/src/experimental/decompression-api/DecompressionApi.ql

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ class DecompressionApiUse extends DataFlow::Node {
2222
// this should find the first argument of Zlib::Inflate.inflate or Zip::File.extract
2323
DecompressionApiUse() {
2424
this = API::getTopLevelMember("Zlib").getMember("Inflate").getAMethodCall("inflate").getArgument(0) or
25-
this = API::getTopLevelMember("Zip").getMember("File").getAMethodCall("open").getArgument(0) or
2625
this = API::getTopLevelMember("Zip").getMember("Entry").getAMethodCall("extract").getArgument(0)
2726
}
2827

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
11
edges
22
| decompression_api.rb:3:31:3:36 | call to params : | decompression_api.rb:3:31:3:44 | ...[...] |
33
| decompression_api.rb:13:44:13:49 | call to params : | decompression_api.rb:13:44:13:57 | ...[...] |
4-
| decompression_api.rb:17:24:17:29 | call to params : | decompression_api.rb:17:24:17:37 | ...[...] |
54
nodes
65
| decompression_api.rb:3:31:3:36 | call to params : | semmle.label | call to params : |
76
| decompression_api.rb:3:31:3:44 | ...[...] | semmle.label | ...[...] |
87
| decompression_api.rb:13:44:13:49 | call to params : | semmle.label | call to params : |
98
| decompression_api.rb:13:44:13:57 | ...[...] | semmle.label | ...[...] |
10-
| decompression_api.rb:17:24:17:29 | call to params : | semmle.label | call to params : |
11-
| decompression_api.rb:17:24:17:37 | ...[...] | semmle.label | ...[...] |
129
subpaths
1310
#select
1411
| decompression_api.rb:3:31:3:44 | ...[...] | decompression_api.rb:3:31:3:36 | call to params : | decompression_api.rb:3:31:3:44 | ...[...] | This call to $@ is unsafe because user-controlled data is used to set the object being decompressed, which could lead to a denial of service attack or malicious code extracted from an unknown source. | call to inflate | call to inflate |
1512
| decompression_api.rb:13:44:13:57 | ...[...] | decompression_api.rb:13:44:13:49 | call to params : | decompression_api.rb:13:44:13:57 | ...[...] | This call to $@ is unsafe because user-controlled data is used to set the object being decompressed, which could lead to a denial of service attack or malicious code extracted from an unknown source. | call to inflate | call to inflate |
16-
| decompression_api.rb:17:24:17:37 | ...[...] | decompression_api.rb:17:24:17:29 | call to params : | decompression_api.rb:17:24:17:37 | ...[...] | This call to $@ is unsafe because user-controlled data is used to set the object being decompressed, which could lead to a denial of service attack or malicious code extracted from an unknown source. | call to open | call to open |

0 commit comments

Comments
 (0)