Skip to content

Commit 62d64d5

Browse files
Jami CogswellJami Cogswell
authored andcommitted
Java: add comments for reflection-related models
1 parent e0c0c97 commit 62d64d5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

java/ql/lib/ext/java.lang.model.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,9 @@ extensions:
140140
- ["java.lang", "Class", "forName", "(String)", "manual"]
141141
- ["java.lang", "Class", "getCanonicalName", "()", "manual"]
142142
- ["java.lang", "Class", "getClassLoader", "()", "manual"]
143-
- ["java.lang", "Class", "getDeclaredConstructor", "(Class[])", "manual"]
144-
- ["java.lang", "Class", "getDeclaredField", "(String)", "manual"]
145-
- ["java.lang", "Class", "getMethod", "(String,Class[])", "manual"]
143+
- ["java.lang", "Class", "getDeclaredConstructor", "(Class[])", "manual"] # This model may be changed to a taint step for an unsafe reflection query in the future.
144+
- ["java.lang", "Class", "getDeclaredField", "(String)", "manual"] # This model may be changed to a taint step for an unsafe reflection query in the future.
145+
- ["java.lang", "Class", "getMethod", "(String,Class[])", "manual"] # This model may be changed to a taint step for an unsafe reflection query in the future.
146146
- ["java.lang", "Class", "getName", "()", "manual"]
147147
- ["java.lang", "Class", "getResource", "(String)", "manual"]
148148
- ["java.lang", "Class", "getResourceAsStream", "(String)", "manual"]

java/ql/lib/ext/java.lang.reflect.model.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ extensions:
33
pack: codeql/java-all
44
extensible: neutralModel
55
data:
6+
# The below models may be changed to taint steps for an unsafe reflection query in the future.
67
- ["java.lang.reflect", "Constructor", "newInstance", "(Object[])", "manual"]
78
- ["java.lang.reflect", "Field", "get", "(Object)", "manual"]
89
- ["java.lang.reflect", "Method", "getName", "()", "manual"]

0 commit comments

Comments
 (0)