Skip to content

Commit 62f847a

Browse files
Apply suggestions from code review
Co-authored-by: Anders Schack-Mulligen <[email protected]>
1 parent 6096080 commit 62f847a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

java/ql/lib/semmle/code/java/frameworks/android/OnActivityResultSource.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class OnActivityResultIncomingIntent extends DataFlow::Node {
4646
.getDeclaringType()
4747
.hasQualifiedName(["android.app", "android.support.v4.app", "androidx.fragment.app"],
4848
"FragmentTransaction") and
49-
any(Argument arg | arg = ma.getAnArgument()).getType() = startingType
49+
ma.getAnArgument().getType() = startingType
5050
or
5151
ma.getMethod().hasName("show") and
5252
ma.getMethod()

java/ql/test/library-tests/frameworks/android/sources/OnActivityResultSourceTest.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import semmle.code.java.dataflow.FlowSources
33
import TestUtilities.InlineFlowTest
44

55
class SourceValueFlowConf extends DefaultValueFlowConf {
6-
override predicate isSource(DataFlow::Node sink) { sink instanceof RemoteFlowSource }
6+
override predicate isSource(DataFlow::Node src) { src instanceof RemoteFlowSource }
77
}
88

99
class SourceInlineFlowTest extends InlineFlowTest {

0 commit comments

Comments
 (0)