ruby: drop a TODO

alexrford · alexrford · commit 687602b6f132 · 2022-05-04T14:06:37.000+01:00
diff --git a/ruby/ql/lib/codeql/ruby/experimental/Rbi.qll b/ruby/ql/lib/codeql/ruby/experimental/Rbi.qll
@@ -70,13 +70,11 @@ module Rbi {
     class RbiTypeAlias extends RbiType, DataFlow::CallNode {
       RbiTypeAlias() { this = API::getTopLevelMember("T").getAMethodCall("type_alias") }
 
-      // TODO: avoid mapping to AST layer
       /**
        * Gets the type aliased by this call.
        */
       RbiType getAliasedType() {
-        result.asExpr() =
-          this.getBlock().asExpr().(ExprNodes::StmtSequenceCfgNode).getLastStmt()
+        result.asExpr() = this.getBlock().asExpr().(ExprNodes::StmtSequenceCfgNode).getLastStmt()
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -70,13 +70,11 @@ module Rbi {`
`70`	`70`	`class RbiTypeAlias extends RbiType, DataFlow::CallNode {`
`71`	`71`	`RbiTypeAlias() { this = API::getTopLevelMember("T").getAMethodCall("type_alias") }`
`72`	`72`
`73`		`- // TODO: avoid mapping to AST layer`
`74`	`73`	`/**`
`75`	`74`	`* Gets the type aliased by this call.`
`76`	`75`	`*/`
`77`	`76`	`RbiType getAliasedType() {`
`78`		`- result.asExpr() =`
`79`		`- this.getBlock().asExpr().(ExprNodes::StmtSequenceCfgNode).getLastStmt()`
	`77`	`+ result.asExpr() = this.getBlock().asExpr().(ExprNodes::StmtSequenceCfgNode).getLastStmt()`
`80`	`78`	`}`
`81`	`79`	`}`
`82`	`80`