Skip to content

Commit 690a09d

Browse files
committed
Python: new-call-graph: pragma[noinline] => pragma[nomagic]
As suggested by @tausbn. Obviously, this needs to be performance tested.
1 parent a3b7273 commit 690a09d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

python/ql/lib/semmle/python/dataflow/new/internal/DataFlowDispatch.qll

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -841,7 +841,7 @@ private module MethodCalls {
841841
* reference to the class `cls`, or to an instance of the class `cls`. The reference the
842842
* attribute-read is made on is `self`.
843843
*/
844-
pragma[noinline]
844+
pragma[nomagic]
845845
private predicate directCall(
846846
CallNode call, Function target, string functionName, Class cls, AttrRead attr, Node self
847847
) {
@@ -850,7 +850,7 @@ private module MethodCalls {
850850
}
851851

852852
/** Extracted to give good join order */
853-
pragma[noinline]
853+
pragma[nomagic]
854854
private predicate directCall_join(
855855
CallNode call, string functionName, Class cls, AttrRead attr, Node self
856856
) {
@@ -872,7 +872,7 @@ private module MethodCalls {
872872
* reference to an implicit `self`/`cls` argument. The reference the attribute-read is
873873
* made on is `self`.
874874
*/
875-
pragma[noinline]
875+
pragma[nomagic]
876876
private predicate callWithinMethodImplicitSelfOrCls(
877877
CallNode call, Function target, string functionName, Class classWithMethod, AttrRead attr,
878878
Node self
@@ -882,7 +882,7 @@ private module MethodCalls {
882882
}
883883

884884
/** Extracted to give good join order */
885-
pragma[noinline]
885+
pragma[nomagic]
886886
private predicate callWithinMethodImplicitSelfOrCls_join(
887887
CallNode call, string functionName, Class classWithMethod, AttrRead attr, Node self
888888
) {
@@ -921,7 +921,7 @@ private module MethodCalls {
921921
* The method call is found by making an attribute read `attr` with the name
922922
* `functionName` on the return value from the `super` call.
923923
*/
924-
pragma[noinline]
924+
pragma[nomagic]
925925
predicate fromSuper(
926926
CallNode call, Function target, string functionName, Class classUsedInSuper, AttrRead attr,
927927
Node self
@@ -931,7 +931,7 @@ private module MethodCalls {
931931
}
932932

933933
/** Extracted to give good join order */
934-
pragma[noinline]
934+
pragma[nomagic]
935935
private predicate fromSuper_join(
936936
CallNode call, string functionName, Class classUsedInSuper, AttrRead attr, Node self
937937
) {

0 commit comments

Comments
 (0)