Merge pull request github#6725 from emilejq/date-format

Java: Remove requirements for final and access mods from DateFormatThreadUnsafe

Author: aschackmull

java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.java

@@ -1,5 +1,5 @@
 class DateFormattingThread implements Runnable {
-    private static DateFormat dateF = new SimpleDateFormat("yyyyMMdd");  // Static field declared
+    public static DateFormat dateF = new SimpleDateFormat("yyyyMMdd");  // Static field declared
 
     public void run() {
         for(int i=0; i < 10; i++){

java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.ql

@@ -16,7 +16,6 @@ import java
 from Field f, Class dateFormat
 where
   f.isStatic() and
-  f.isFinal() and
   (f.isPublic() or f.isProtected()) and
   dateFormat.hasQualifiedName("java.text", "DateFormat") and
   f.getType().(RefType).hasSupertype*(dateFormat) and