C#: Fix issue with TestLibraries not being excluded in the Telemetry queries and add Moq as a testlibrary.

michaelnebel · michaelnebel · commit 6c6b4ce13138 · 2022-10-04T14:58:37.000+02:00
diff --git a/csharp/ql/src/Telemetry/ExternalApi.qll b/csharp/ql/src/Telemetry/ExternalApi.qll
@@ -17,8 +17,10 @@ private import semmle.code.csharp.security.dataflow.flowsources.Remote
 class TestLibrary extends RefType {
   TestLibrary() {
     this.getNamespace()
-        .getName()
-        .matches(["NUnit.Framework%", "Xunit%", "Microsoft.VisualStudio.TestTools.UnitTesting%"])
+        .getQualifiedName()
+        .matches([
+            "NUnit.Framework%", "Xunit%", "Microsoft.VisualStudio.TestTools.UnitTesting%", "Moq%"
+          ])
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,10 @@ private import semmle.code.csharp.security.dataflow.flowsources.Remote`
`17`	`17`	`class TestLibrary extends RefType {`
`18`	`18`	`TestLibrary() {`
`19`	`19`	`this.getNamespace()`
`20`		`- .getName()`
`21`		`- .matches(["NUnit.Framework%", "Xunit%", "Microsoft.VisualStudio.TestTools.UnitTesting%"])`
	`20`	`+ .getQualifiedName()`
	`21`	`+ .matches([`
	`22`	`+ "NUnit.Framework%", "Xunit%", "Microsoft.VisualStudio.TestTools.UnitTesting%", "Moq%"`
	`23`	`+ ])`
`22`	`24`	`}`
`23`	`25`	`}`
`24`	`26`