Merge pull request github#10768 from erik-krogh/fixFileLoops

JS: fix that js/file-system-race could have FPs related to loops

Author: erik-krogh

javascript/ql/src/Security/CWE-367/FileSystemRace.ql

@@ -106,7 +106,7 @@ predicate useAfterCheck(FileCheck check, FileUse use) {
     )
   )
   or
-  check.getBasicBlock().getASuccessor+() = use.getBasicBlock()
+  check.getBasicBlock().(ReachableBasicBlock).strictlyDominates(use.getBasicBlock())
 }
 
 from FileCheck check, FileUse use

javascript/ql/src/change-notes/2022-10-04-fix-loops-file-system-race.md

@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* Removed some false positives from the `js/file-system-race` query by requiring that the file-check dominates the file-access.

javascript/ql/test/query-tests/Security/CWE-367/tst.js

@@ -41,3 +41,8 @@ const filePath3 = createFile();
 if (fs.existsSync(filePath3)) {
   fs.readFileSync(filePath3); // OK - a read after an existence check is OK 
 }
+
+const filePath4 = createFile();
+while(Math.random() > 0.5) {
+    fs.open(filePath4); // OK - it is only ever opened here.
+}