JS: Change getAParameter to not return the receiver

asgerf · asgerf · commit 73071bdc0894 · 2022-03-23T10:42:51.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/ApiGraphs.qll b/javascript/ql/lib/semmle/javascript/ApiGraphs.qll
@@ -187,8 +187,7 @@ module API {
     }
 
     /**
-     * Gets a node representing a parameter or the receiver of the function represented by this
-     * node.
+     * Gets a node representing a parameter of the function represented by this node.
      *
      * This predicate may result in a mix of parameters from different call sites in cases where
      * there are multiple invocations of this API component.
@@ -198,8 +197,6 @@ module API {
     Node getAParameter() {
       Stages::ApiStage::ref() and
       result = this.getParameter(_)
-      or
-      result = this.getReceiver()
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -187,8 +187,7 @@ module API {`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`/**`
`190`		`- * Gets a node representing a parameter or the receiver of the function represented by this`
`191`		`- * node.`
	`190`	`+ * Gets a node representing a parameter of the function represented by this node.`
`192`	`191`	`*`
`193`	`192`	`* This predicate may result in a mix of parameters from different call sites in cases where`
`194`	`193`	`* there are multiple invocations of this API component.`
`@@ -198,8 +197,6 @@ module API {`
`198`	`197`	`Node getAParameter() {`
`199`	`198`	`Stages::ApiStage::ref() and`
`200`	`199`	`result = this.getParameter(_)`
`201`		`- or`
`202`		`- result = this.getReceiver()`
`203`	`200`	`}`
`204`	`201`
`205`	`202`	`/**`