Ruby: fix missing 'self' parameters in ModuleNode.getAnImmediateReferenc

asgerf · asgerf · commit 7332cec9a55c · 2023-04-17T12:47:23.000+02:00
diff --git a/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPublic.qll b/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPublic.qll
@@ -890,6 +890,9 @@ class ModuleNode instanceof Module {
   /** Gets a constant or `self` variable that refers to this module. */
   LocalSourceNode getAnImmediateReference() {
     result.asExpr().getExpr() = super.getAnImmediateReference()
+    or
+    // Include 'self' parameters; these are not expressions and so not found by the case above
+    result = this.getAnOwnModuleSelf()
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -890,6 +890,9 @@ class ModuleNode instanceof Module {`
`890`	`890`	/** Gets a constant or `self` variable that refers to this module. */
`891`	`891`	`LocalSourceNode getAnImmediateReference() {`
`892`	`892`	`result.asExpr().getExpr() = super.getAnImmediateReference()`
	`893`	`+ or`
	`894`	`+ // Include 'self' parameters; these are not expressions and so not found by the case above`
	`895`	`+ result = this.getAnOwnModuleSelf()`
`893`	`896`	`}`
`894`	`897`
`895`	`898`	`/**`