Skip to content

Commit 73f88fb

Browse files
committed
changes based on review
1 parent f3f3b94 commit 73f88fb

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

ql/ql/src/queries/performance/TransitiveStep.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,5 +161,5 @@ predicate transitiveDelta(Call rec, TransitivelyClosedCall tc) {
161161

162162
from Call rec, TransitivelyClosedCall tc, AstNode reason
163163
where transitiveDelta(rec, tc) and reason = tc.getReason()
164-
select tc, "This recursive delta $@, which may be a performance problem.", reason,
165-
"is transively closed"
164+
select tc, "This recursive delta is $@, which may be a performance problem.", reason,
165+
"transitively closed"

ql/ql/src/queries/performance/UnusedField.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,6 @@ where
3131
)
3232
) and
3333
(if clz = implClz then extraMsg = "." else extraMsg = " of any class between it and $@.")
34-
select clz, "This class declares $@ that is not used in the characteristic predicate" + extraMsg,
34+
select clz,
35+
"This class declares the $@ but does not bind it in the characteristic predicate" + extraMsg,
3536
field, "field " + field.getName(), implClz, implClz.getName()

ql/ql/src/queries/style/DeadCode.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ import codeql_ql.style.DeadCodeQuery
1212

1313
from AstNode node
1414
where isDead(node)
15-
select node, "Code is dead."
15+
select node, "This code is never used, and it's not publicly exported."
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
| Foo.qll:2:21:2:25 | ClasslessPredicate dead1 | Code is dead. |
2-
| Foo.qll:6:13:6:17 | ClasslessPredicate dead2 | Code is dead. |
1+
| Foo.qll:2:21:2:25 | ClasslessPredicate dead1 | This code is never used, and it's not publicly exported. |
2+
| Foo.qll:6:13:6:17 | ClasslessPredicate dead2 | This code is never used, and it's not publicly exported. |

0 commit comments

Comments
 (0)