Skip to content

Commit 7453533

Browse files
committed
Python: Expand setdefault tests
1 parent 7fa84a3 commit 7453533

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

python/ql/test/experimental/dataflow/fieldflow/test_dict.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,22 +31,27 @@ def SINK_F(x):
3131
# Actual tests
3232
# ------------------------------------------------------------------------------
3333

34-
@expects(3) # $ unresolved_call=expects(..) unresolved_call=expects(..)(..)
34+
@expects(2) # $ unresolved_call=expects(..) unresolved_call=expects(..)(..)
3535
def test_dict_literal():
3636
d = {"key": SOURCE}
3737
SINK(d["key"]) # $ flow="SOURCE, l:-1 -> d['key']"
3838
SINK(d.get("key")) # $ flow="SOURCE, l:-2 -> d.get(..)"
39-
SINK(d.setdefault("key", NONSOURCE)) # $ flow="SOURCE, l:-3 -> d.setdefault(..)"
4039

4140

42-
@expects(3) # $ unresolved_call=expects(..) unresolved_call=expects(..)(..)
41+
@expects(2) # $ unresolved_call=expects(..) unresolved_call=expects(..)(..)
4342
def test_dict_update():
4443
d = {}
4544
d["key"] = SOURCE
4645
SINK(d["key"]) # $ flow="SOURCE, l:-1 -> d['key']"
4746
SINK(d.get("key")) # $ flow="SOURCE, l:-2 -> d.get(..)"
48-
SINK(d.setdefault("key", NONSOURCE)) # $ flow="SOURCE, l:-3 -> d.setdefault(..)"
4947

48+
@expects(3) # $ unresolved_call=expects(..) unresolved_call=expects(..)(..)
49+
def test_setdefault():
50+
d = {}
51+
x = d.setdefault("key", SOURCE)
52+
SINK(x) # $ MISSING: flow="SOURCE, l:-1 -> d.setdefault(..)"
53+
SINK(d["key"]) # $ flow="SOURCE, l:-2 -> d['key']"
54+
SINK(d.setdefault("key", NONSOURCE)) # $ flow="SOURCE, l:-3 -> d.setdefault(..)"
5055

5156
@expects(2) # $ unresolved_call=expects(..) unresolved_call=expects(..)(..)
5257
def test_dict_override():

0 commit comments

Comments
 (0)