Python: Avoid toString usage :O

RasmusWL · RasmusWL · commit 75bc532d10ed · 2022-03-04T11:41:22.000+01:00
diff --git a/python/ql/lib/semmle/python/frameworks/Libtaxii.qll b/python/ql/lib/semmle/python/frameworks/Libtaxii.qll
@@ -25,7 +25,7 @@ private module Libtaxii {
   private class ParseCall extends HTTP::Client::Request::Range, DataFlow::CallCfgNode {
     ParseCall() {
       this = API::moduleImport("libtaxii").getMember("common").getMember("parse").getACall() and
-      this.getArgByName("allow_url").asExpr().toString() = "True"
+      this.getArgByName("allow_url").getALocalSource().asExpr() = any(True t)
     }
 
     override DataFlow::Node getAUrlPart() { result in [this.getArg(0), this.getArgByName("s")] }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ private module Libtaxii {`
`25`	`25`	`private class ParseCall extends HTTP::Client::Request::Range, DataFlow::CallCfgNode {`
`26`	`26`	`ParseCall() {`
`27`	`27`	`this = API::moduleImport("libtaxii").getMember("common").getMember("parse").getACall() and`
`28`		`- this.getArgByName("allow_url").asExpr().toString() = "True"`
	`28`	`+ this.getArgByName("allow_url").getALocalSource().asExpr() = any(True t)`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`override DataFlow::Node getAUrlPart() { result in [this.getArg(0), this.getArgByName("s")] }`