Skip to content

Commit 85de9f3

Browse files
committed
Fix naming of OSCheck method
1 parent a7adbb7 commit 85de9f3

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

java/ql/lib/semmle/code/java/os/OSCheck.qll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ private class IsWindowsFromSystemProp extends IsWindowsGuard instanceof MethodAc
7171
* Holds when the Guard is an equality check between the system property with the name `propertyName`
7272
* and the string or char constant `compareToLiteral`.
7373
*/
74-
private Guard isOsFromFieldEqualityCheck(string propertyName, string compareToLiteral) {
74+
private Guard isOsFromSystemPropertyEqualityCheck(string propertyName, string compareToLiteral) {
7575
result
7676
.isEquality(getSystemProperty(propertyName),
7777
any(Literal literal |
@@ -81,19 +81,19 @@ private Guard isOsFromFieldEqualityCheck(string propertyName, string compareToLi
8181
}
8282

8383
private class IsWindowsFromCharPathSeperator extends IsWindowsGuard {
84-
IsWindowsFromCharPathSeperator() { this = isOsFromFieldEqualityCheck("path.separator", "\\") }
84+
IsWindowsFromCharPathSeperator() { this = isOsFromSystemPropertyEqualityCheck("path.separator", "\\") }
8585
}
8686

8787
private class IsWindowsFromCharSeperator extends IsWindowsGuard {
88-
IsWindowsFromCharSeperator() { this = isOsFromFieldEqualityCheck("file.separator", ";") }
88+
IsWindowsFromCharSeperator() { this = isOsFromSystemPropertyEqualityCheck("file.separator", ";") }
8989
}
9090

9191
private class IsUnixFromCharPathSeperator extends IsUnixGuard {
92-
IsUnixFromCharPathSeperator() { this = isOsFromFieldEqualityCheck("path.separator", "/") }
92+
IsUnixFromCharPathSeperator() { this = isOsFromSystemPropertyEqualityCheck("path.separator", "/") }
9393
}
9494

9595
private class IsUnixFromCharSeperator extends IsUnixGuard {
96-
IsUnixFromCharSeperator() { this = isOsFromFieldEqualityCheck("file.separator", ":") }
96+
IsUnixFromCharSeperator() { this = isOsFromSystemPropertyEqualityCheck("file.separator", ":") }
9797
}
9898

9999
private class IsUnixFromSystemProp extends IsAnyUnixGuard instanceof MethodAccess {

0 commit comments

Comments
 (0)