Skip to content

Commit 9790594

Browse files
committed
Ruby: Bugfix after HTTP::Client::Request change
I guess this is not 100% accurate any longer since the base class is only a `DataFlow::Node` now... I guess we could make it a `DataFlow::CallNode` in the Concept definition.
1 parent 9eda630 commit 9790594

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ruby/ql/lib/codeql/ruby/security/InsecureDownloadCustomizations.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ module InsecureDownload {
143143
hasUnsafeExtension(req.getAUrlPart().asExpr().getConstantValue().getString())
144144
}
145145

146-
override DataFlow::Node getDownloadCall() { result.asExpr().getExpr() = req }
146+
override DataFlow::Node getDownloadCall() { result = req }
147147

148148
override DataFlow::FlowState getALabel() {
149149
result instanceof Label::SensitiveInsecure
@@ -193,6 +193,6 @@ module InsecureDownload {
193193

194194
override DataFlow::FlowState getALabel() { result instanceof Label::Insecure }
195195

196-
override DataFlow::Node getDownloadCall() { result.asExpr().getExpr() = request }
196+
override DataFlow::Node getDownloadCall() { result = request }
197197
}
198198
}

0 commit comments

Comments
 (0)