Skip to content

Commit 9a8d1f8

Browse files
committed
Take back non-trivial tests
1 parent 0819090 commit 9a8d1f8

File tree

2 files changed

+34
-0
lines changed

2 files changed

+34
-0
lines changed

python/ql/test/experimental/query-tests/Security/CWE-943/mongoengine_bad.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,22 @@ def connect_find():
2121
db = me.connect('mydb')
2222
return db.movie.find({'name': json_search})
2323

24+
@app.route("/connection_connect_find")
25+
def connection_connect_find():
26+
unsafe_search = request.args['search']
27+
json_search = json.loads(unsafe_search)
28+
29+
db = connect('mydb')
30+
return db.movie.find({'name': json_search})
31+
32+
@app.route("/get_db_find")
33+
def get_db_find():
34+
unsafe_search = request.args['search']
35+
json_search = json.loads(unsafe_search)
36+
37+
db = me.get_db()
38+
return db.movie.find({'name': json_search})
39+
2440
@app.route("/connection_get_db_find")
2541
def connection_get_db_find():
2642
unsafe_search = request.args['search']

python/ql/test/experimental/query-tests/Security/CWE-943/mongoengine_good.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,15 @@ def connect_find():
2323
db = me.connect('mydb')
2424
return db.movie.find({'name': json_search})
2525

26+
@app.route("/connection_connect_find")
27+
def connection_connect_find():
28+
unsafe_search = request.args['search']
29+
json_search = json.loads(unsafe_search)
30+
safe_search = sanitize(json_search)
31+
32+
db = connect('mydb')
33+
return db.movie.find({'name': json_search})
34+
2635
@app.route("/subclass_objects")
2736
def subclass_objects():
2837
unsafe_search = request.args['search']
@@ -31,6 +40,15 @@ def subclass_objects():
3140

3241
return Movie.objects(__raw__=safe_search)
3342

43+
@app.route("/get_db_find")
44+
def get_db_find():
45+
unsafe_search = request.args['search']
46+
json_search = json.loads(unsafe_search)
47+
safe_search = sanitize(json_search)
48+
49+
db = me.get_db()
50+
return db.movie.find({'name': safe_search})
51+
3452
@app.route("/connection_get_db_find")
3553
def connection_get_db_find():
3654
unsafe_search = request.args['search']

0 commit comments

Comments
 (0)