Skip to content

Commit 9abd599

Browse files
committed
Ruby: treat Faraday#run_request as remote source
1 parent 5cadd3c commit 9abd599

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
category: minorAnalysis
3+
---
4+
* The response value returned by the `Faraday#run_request` method is now also considered a source of remote input.

ruby/ql/lib/codeql/ruby/frameworks/http_clients/Faraday.qll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ class FaradayHttpRequest extends Http::Client::Request::Range, DataFlow::CallNod
3737
API::getTopLevelMember("Faraday").getInstance()
3838
] and
3939
requestNode =
40-
connectionNode.getReturn(["get", "head", "delete", "post", "put", "patch", "trace"]) and
40+
connectionNode
41+
.getReturn(["get", "head", "delete", "post", "put", "patch", "trace", "run_request"]) and
4142
this = requestNode.asSource() and
4243
connectionUse = connectionNode.asSource()
4344
}

0 commit comments

Comments
 (0)