Skip to content

Commit 9e0b112

Browse files
committed
Remove now-unnecessary models and tests
1 parent 490168f commit 9e0b112

File tree

4 files changed

+2
-568
lines changed

4 files changed

+2
-568
lines changed

java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ private module Frameworks {
8080
private import semmle.code.java.frameworks.android.Android
8181
private import semmle.code.java.frameworks.android.Intent
8282
private import semmle.code.java.frameworks.android.XssSinks
83-
private import semmle.code.java.frameworks.android.Intent
8483
private import semmle.code.java.frameworks.ApacheHttp
8584
private import semmle.code.java.frameworks.apache.Collections
8685
private import semmle.code.java.frameworks.apache.Lang

java/ql/lib/semmle/code/java/frameworks/android/Android.qll

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -219,25 +219,8 @@ class CreateFromParcelMethod extends Method {
219219
}
220220
}
221221

222-
private class TaintPropagationModels extends SummaryModelCsv {
222+
private class ParcelPropagationModels extends SummaryModelCsv {
223223
override predicate row(string s) {
224-
// BaseBundle getters. These are also modelled on Bundle because BaseBundle was factored out of Bundle
225-
// in Android 5.0; before that these methods were declared directly on Bundle.
226-
s =
227-
"android.os;" + ["BaseBundle", "Bundle"] + ";true;get" +
228-
["Boolean", "Double", "Int", "Long", "String"] + ["", "Array"] +
229-
";;;Argument[-1];ReturnValue;taint"
230-
or
231-
// Bundle getters
232-
s =
233-
"android.os;Bundle;true;get" +
234-
[
235-
"Binder", "Bundle", "Byte", "ByteArray", "Char", "CharArray", "CharSequence",
236-
"CharSequenceArray", "CharSequenceArrayList", "Float", "FloatArray", "IntegerArrayList",
237-
"Parcelable", "ParcelableArray", "ParcelableArrayList", "Serializable", "Short",
238-
"ShortArray", "Size", "SizeF", "SparseParcelableArray", "StringArrayList"
239-
] + ";;;Argument[-1];ReturnValue;taint"
240-
or
241224
// Parcel readers that return their value
242225
s =
243226
"android.os;Parcel;false;read" +

0 commit comments

Comments
 (0)