Skip to content

Commit a1a7c31

Browse files
committed
Ruby: drop an outdated TODO
1 parent 9fe7d6e commit a1a7c31

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

ruby/ql/lib/codeql/ruby/security/CleartextStorageCustomizations.qll

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,6 @@ module CleartextStorage {
4444
* A node representing data written to a database using an ORM system.
4545
*/
4646
private class OrmWriteAccessValueAsSink extends Sink {
47-
// instanceof OrmWriteAccess {
48-
// TODO: we generally won't get flow from `value` to `this`
49-
// Should the node be on value? Or should there be an additional flow step from
50-
// value to the write node?
5147
OrmWriteAccessValueAsSink() {
5248
exists(OrmWriteAccess write, string fieldName |
5349
fieldName = write.getFieldNameAssignedTo(this)

0 commit comments

Comments
 (0)