Skip to content

Commit a2e9c2f

Browse files
Apply suggestions from code review
Co-authored-by: Marcono1234 <[email protected]>
1 parent c13bf2a commit a2e9c2f

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

java/ql/src/semmle/code/java/frameworks/Mail.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class MailSessionGetInstanceMethod extends Method {
2020
}
2121

2222
/**
23-
* A subtype of the class `org.apache.commons.mail.Mail`
23+
* A subtype of the class `org.apache.commons.mail.Email`
2424
*/
2525
class ApacheEmail extends Class {
2626
ApacheEmail() { this.getASupertype*().hasQualifiedName("org.apache.commons.mail", "Email") }

java/ql/src/semmle/code/java/security/Mail.qll

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,7 @@ predicate hasSslCertificateCheck(VarAccess va) {
5656
private string getStringValue(Expr expr) {
5757
result = expr.(CompileTimeConstantExpr).getStringValue()
5858
or
59-
result = getStringValue(expr.(AddExpr).getLeftOperand())
60-
or
61-
result = getStringValue(expr.(AddExpr).getRightOperand())
59+
result = getStringValue(expr.(AddExpr).getAnOperand())
6260
}
6361

6462
/**

0 commit comments

Comments
 (0)