Remove redundant conditions from HostnameVerificationCall.isIgnored

smowton · web-flow · commit a62eae5a1eff · 2022-02-14T16:26:41.000Z
diff --git a/java/ql/src/experimental/Security/CWE/CWE-297/IgnoredHostnameVerification.ql b/java/ql/src/experimental/Security/CWE/CWE-297/IgnoredHostnameVerification.ql
@@ -22,8 +22,6 @@ private class HostnameVerificationCall extends MethodAccess {
 
   /** Holds if the result of the call is not used. */
   predicate isIgnored() {
-    not exists(Expr expr | this = expr.getAChildExpr()) and
-    not exists(IfStmt ifStmt | this = ifStmt.getCondition()) and
     this = any(ExprStmt es).getExpr()
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,6 @@ private class HostnameVerificationCall extends MethodAccess {`
`22`	`22`
`23`	`23`	`/** Holds if the result of the call is not used. */`
`24`	`24`	`predicate isIgnored() {`
`25`		`- not exists(Expr expr \| this = expr.getAChildExpr()) and`
`26`		`- not exists(IfStmt ifStmt \| this = ifStmt.getCondition()) and`
`27`	`25`	`this = any(ExprStmt es).getExpr()`
`28`	`26`	`}`
`29`	`27`	`}`