Skip to content

Commit a6736a9

Browse files
Apply doc review suggestions -
fix typos and capitilisation; reword description.
1 parent c71586e commit a6736a9

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

java/ql/src/Security/CWE/CWE-925/ImproperIntentVerification.qhelp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@
66

77
<overview>
88
<p>
9-
When an android application uses a <code>BroadcastReciever</code> to receive intents,
9+
When an Android application uses a <code>BroadcastReceiver</code> to receive intents,
1010
it is also able to receive explicit intents that are sent directly to it, regardless of its filter.
1111

1212
Certain intent actions are only able to be sent by the operating system, not third-party applications.
1313
However, a <code>BroadcastReceiver</code> that is registered to receive system intents is still able to receive
14-
other intents from a third-party application, so it should check that the intent received has the expected action.
15-
Otherwise, a third-party application could impersonate the system this way and cause unintended behavior, such as a denial of service.
14+
intents from a third-party application, so it should check that the intent received has the expected action.
15+
Otherwise, a third-party application could impersonate the system this way to cause unintended behavior, such as a denial of service.
1616
</p>
1717
</overview>
1818

java/ql/src/Security/CWE/CWE-925/ImproperIntentVerification.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
2-
* @name Improper Verification of Intent by Broadcast Receiver
3-
* @description The Android application uses a Broadcast Receiver that receives an Intent but does not properly verify that the Intent came from an authorized source.
2+
* @name Improper verification of intent by broadcast receiver
3+
* @description A broadcast reciever that does not verify intents it recieves may be susceptible to unintended behaviour by third party applications sending it explicit intents.
44
* @kind problem
55
* @problem.severity warning
66
* @security-severity 8.2
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
category: newQuery
33
---
4-
* A new query "Improper Verification of Intent by Broadcast Receiver" (`java/improper-intent-verification`) has been added.
4+
* A new query "Improper verification of intent by broadcast receiver" (`java/improper-intent-verification`) has been added.
55
This query finds instances of Android `BroadcastReceiver`s that don't verify the action string of received intents when registered
66
to receive system intents.

0 commit comments

Comments
 (0)