Skip to content

Commit ad8f0fc

Browse files
committed
Java: Address review comments.
1 parent 30a891c commit ad8f0fc

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

java/ql/lib/semmle/code/java/dataflow/FlowSummary.qll

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ private newtype TSummarizedCallableBase =
9999
TSyntheticCallable(SyntheticCallable c)
100100

101101
/**
102-
* A callable with a flow summary. This is either a regular `Callable` or a
103-
* `SyntheticCallable`.
102+
* A callable that may have a flow summary. This is either a regular `Callable`
103+
* or a `SyntheticCallable`.
104104
*/
105105
class SummarizedCallableBase extends TSummarizedCallableBase {
106106
/** Gets a textual representation of this callable. */
@@ -149,9 +149,9 @@ class SummarizedCallableBase extends TSummarizedCallableBase {
149149
Type getReturnType() {
150150
result = this.asCallable().getReturnType()
151151
or
152-
result = this.asSyntheticCallable().getReturnType()
153-
or
154152
exists(SyntheticCallable sc | sc = this.asSyntheticCallable() |
153+
result = sc.getReturnType()
154+
or
155155
not exists(sc.getReturnType()) and
156156
result instanceof TypeObject
157157
)
@@ -161,10 +161,10 @@ class SummarizedCallableBase extends TSummarizedCallableBase {
161161
class SummarizedCallable = Impl::Public::SummarizedCallable;
162162

163163
/**
164-
* An adaptor class to add the flow summaries specified on `SyntheticCallable`
164+
* An adapter class to add the flow summaries specified on `SyntheticCallable`
165165
* to `SummarizedCallable`.
166166
*/
167-
private class SummarizedSyntheticCallableAdaptor extends SummarizedCallable, TSyntheticCallable {
167+
private class SummarizedSyntheticCallableAdapter extends SummarizedCallable, TSyntheticCallable {
168168
override predicate propagatesFlow(
169169
SummaryComponentStack input, SummaryComponentStack output, boolean preservesValue
170170
) {

0 commit comments

Comments
 (0)