Skip to content

Commit b1bad27

Browse files
committed
only activate the PrefixString label in Query.qll files
1 parent 8a5b166 commit b1bad27

File tree

5 files changed

+17
-1
lines changed

5 files changed

+17
-1
lines changed

javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/XssATM.qll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,10 @@ private class PrefixStringSanitizerActivated extends TaintTracking::SanitizerGua
116116
PrefixStringSanitizerActivated() { this = this }
117117
}
118118

119+
private class PrefixStringActivated extends DataFlow::FlowLabel, DomBasedXss::PrefixString {
120+
PrefixStringActivated() { this = this }
121+
}
122+
119123
private class QuoteGuard extends TaintTracking::SanitizerGuardNode, Shared::QuoteGuard {
120124
QuoteGuard() { this = this }
121125
}

javascript/ql/lib/semmle/javascript/security/dataflow/DomBasedXssCustomizations.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ module DomBasedXss {
322322
/**
323323
* A flow-label representing tainted values where the prefix is attacker controlled.
324324
*/
325-
class PrefixString extends DataFlow::FlowLabel {
325+
abstract class PrefixString extends DataFlow::FlowLabel {
326326
PrefixString() { this = "PrefixString" }
327327
}
328328

javascript/ql/lib/semmle/javascript/security/dataflow/DomBasedXssQuery.qll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,10 @@ private class PrefixStringSanitizerActivated extends TaintTracking::SanitizerGua
132132
PrefixStringSanitizerActivated() { this = this }
133133
}
134134

135+
private class PrefixStringActivated extends DataFlow::FlowLabel, PrefixString {
136+
PrefixStringActivated() { this = this }
137+
}
138+
135139
private class QuoteGuard extends TaintTracking::SanitizerGuardNode, Shared::QuoteGuard {
136140
QuoteGuard() { this = this }
137141
}

javascript/ql/lib/semmle/javascript/security/dataflow/UnsafeHtmlConstructionQuery.qll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,10 @@ private class PrefixStringSanitizer extends TaintTracking::SanitizerGuardNode,
5454
PrefixStringSanitizer() { this = this }
5555
}
5656

57+
private class PrefixString extends DataFlow::FlowLabel, DomBasedXss::PrefixString {
58+
PrefixString() { this = this }
59+
}
60+
5761
private class QuoteGuard extends TaintTracking::SanitizerGuardNode, Shared::QuoteGuard {
5862
QuoteGuard() { this = this }
5963
}

javascript/ql/lib/semmle/javascript/security/dataflow/XssThroughDomQuery.qll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,10 @@ private class PrefixStringSanitizer extends TaintTracking::SanitizerGuardNode,
5959
PrefixStringSanitizer() { this = this }
6060
}
6161

62+
private class PrefixString extends DataFlow::FlowLabel, DomBasedXss::PrefixString {
63+
PrefixString() { this = this }
64+
}
65+
6266
private class QuoteGuard extends TaintTracking::SanitizerGuardNode, Shared::QuoteGuard {
6367
QuoteGuard() { this = this }
6468
}

0 commit comments

Comments
 (0)