Skip to content

Commit b46e4cc

Browse files
committed
Ruby: drop SanitizerIn from ClearTextLoggingQuery
1 parent 7b4af39 commit b46e4cc

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

ruby/ql/lib/codeql/ruby/security/CleartextLoggingCustomizations.qll

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@ module CleartextLogging {
3737
*/
3838
abstract class Sanitizer extends DataFlow::Node { }
3939

40-
/**
41-
* A node that receives sanitized sensitive information.
42-
*/
43-
abstract class SanitizerIn extends DataFlow::Node { }
44-
4540
/**
4641
* Holds if `re` may be a regular expression that can be used to sanitize
4742
* sensitive data with a call to `sub`.
@@ -83,7 +78,7 @@ module CleartextLogging {
8378
* Logger.new(STDOUT).info password
8479
* ```
8580
*/
86-
private class MaskingReplacerSanitizedNode extends SanitizerIn {
81+
private class MaskingReplacerSanitizedNode extends Sanitizer {
8782
MaskingReplacerSanitizedNode() {
8883
exists(Ssa::Definition def |
8984
exists(MaskingReplacerSanitizer maskCall |

ruby/ql/lib/codeql/ruby/security/CleartextLoggingQuery.qll

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,6 @@ class Configuration extends TaintTracking::Configuration {
2828
node instanceof CleartextLogging::Sanitizer
2929
}
3030

31-
override predicate isSanitizerIn(DataFlow::Node node) {
32-
node instanceof CleartextLogging::SanitizerIn
33-
}
34-
3531
override predicate isAdditionalTaintStep(DataFlow::Node nodeFrom, DataFlow::Node nodeTo) {
3632
CleartextLogging::isAdditionalTaintStep(nodeFrom, nodeTo)
3733
}

0 commit comments

Comments
 (0)