Skip to content

Commit b5198bd

Browse files
apply suggestions from doc review
Co-authored-by: mc <[email protected]>
1 parent abd8761 commit b5198bd

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
---
22
category: newQuery
33
---
4-
* The `js/http-dependency` query has been added. It detects depedencies that are downloaded using an unencrypted connection.
4+
* The `js/insecure-dependency` query has been added. It detects depedencies that are downloaded using an unencrypted connection.

javascript/ql/src/Security/CWE-300/InsecureDependencyResolution.qhelp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
<overview>
77
<p>
88
Using an insecure protocol like HTTP or FTP to download build dependencies makes the build process vulnerable to a
9-
Man in the Middle (MITM) attack.
9+
man-in-the-middle (MITM) attack.
1010
</p>
1111
<p>
12-
This can allow attackers to inject malicious code into the downloaded dependencies and thereby
12+
This can allow attackers to inject malicious code into the downloaded dependencies, and thereby
1313
infect the build artifacts and execute arbitrary code on the machine building the artifacts.
1414
</p>
1515

@@ -46,10 +46,10 @@ The fix is to change the protocol to HTTPS.
4646
</a>
4747
</li>
4848
<li>
49-
Wikipedia: <a href="https://en.wikipedia.org/wiki/Supply_chain_attack">Supply chain attack</a>
49+
Wikipedia: <a href="https://en.wikipedia.org/wiki/Supply_chain_attack">Supply chain attack.</a>
5050
</li>
5151
<li>
52-
Wikipedia: <a href="https://en.wikipedia.org/wiki/Man-in-the-middle_attack">Man-in-the-middle attack</a>
52+
Wikipedia: <a href="https://en.wikipedia.org/wiki/Man-in-the-middle_attack">Man-in-the-middle attack.</a>
5353
</li>
5454
</references>
5555
</qhelp>

javascript/ql/src/Security/CWE-300/InsecureDependencyResolution.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/**
22
* @name Dependency download using unencrypted communication channel
33
* @description Using unencrypted protocols to fetch dependencies can leave an application
4-
* open to man in the middle attacks.
4+
* open to man-in-the-middle attacks.
55
* @kind problem
66
* @problem.severity warning
77
* @security-severity 8.1

0 commit comments

Comments
 (0)