Skip to content

Commit b6270eb

Browse files
Apply suggestions from documentation review
Co-authored-by: Felicity Chapman <[email protected]>
1 parent b94b781 commit b6270eb

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

java/ql/src/Security/CWE/CWE-926/ContentProviderIncompletePermissions.qhelp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
</overview>
1717

1818
<recommendation>
19-
<p>To prevent permission bypass, <code>provider</code> elements should either
19+
<p>To prevent permission bypass, you should create <code>provider</code> elements that either
2020
specify both the <code>android:readPermission</code>
2121
and <code>android:writePermission</code> attributes, or specify
2222
the <code>android:permission</code> attribute.
@@ -26,13 +26,13 @@
2626
<example>
2727

2828
<p>In the following two (bad) examples, the provider is configured with only
29-
read or write permissions.</p>
29+
read or write permissions. This allows a malicious application to bypass the permission check by requesting access to the unrestricted operation.</p>
3030

3131
<sample src="ContentProviderIncompletePermissionsReadOnly.xml"/>
3232

3333
<sample src="ContentProviderIncompletePermissionsWriteOnly.xml"/>
3434

35-
<p>In the following (good) examples, the provider is configured with full permissions.</p>
35+
<p>In the following (good) examples, the provider is configured with full permissions, protecting it from a permissions bypass.</p>
3636

3737
<sample src="ContentProviderIncompletePermissionsReadWrite.xml"/>
3838

0 commit comments

Comments
 (0)