Ruby: fix alert

alexrford · alexrford · commit b956616a5670 · 2022-04-25T11:25:57.000+01:00
diff --git a/ruby/ql/lib/codeql/ruby/experimental/Rbi.qll b/ruby/ql/lib/codeql/ruby/experimental/Rbi.qll
@@ -26,10 +26,8 @@ module Rbi {
     abstract class RbiType extends DataFlow::Node { }
 
     class ConstantReadAccessAsRbiType extends RbiType {
-      private ExprNodes::ConstantReadAccessCfgNode acc;
-
       ConstantReadAccessAsRbiType() {
-        acc = this.asExpr()
+        this.asExpr() instanceof ExprNodes::ConstantReadAccessCfgNode
         // TODO: should this class be more restrictive?
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -26,10 +26,8 @@ module Rbi {`
`26`	`26`	`abstract class RbiType extends DataFlow::Node { }`
`27`	`27`
`28`	`28`	`class ConstantReadAccessAsRbiType extends RbiType {`
`29`		`- private ExprNodes::ConstantReadAccessCfgNode acc;`
`30`		`-`
`31`	`29`	`ConstantReadAccessAsRbiType() {`
`32`		`- acc = this.asExpr()`
	`30`	`+ this.asExpr() instanceof ExprNodes::ConstantReadAccessCfgNode`
`33`	`31`	`// TODO: should this class be more restrictive?`
`34`	`32`	`}`
`35`	`33`	`}`