Skip to content

Commit bb3bf64

Browse files
update example with both AES and Blowfish for better clarity
1 parent b840a41 commit bb3bf64

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

swift/ql/src/queries/Security/CWE-321/HardcodedEncryptionKey.swift

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,16 @@ func encrypt(padding : Padding) {
88
let ivString = getRandomIV()
99
_ = try AES(key: key, blockMode: CBC(), padding: padding)
1010
_ = try AES(key: keyString, iv: ivString)
11-
11+
_ = try Blowfish(key: key, blockMode: CBC(), padding: padding)
12+
_ = try Blowfish(key: keyString, iv: ivString)
1213

1314

1415
// GOOD: Using randomly generated keys for encryption
1516
let key = (0..<10).map({ _ in UInt8.random(in: 0...UInt8.max) })
1617
let keyString = String(cString: key)
1718
let ivString = getRandomIV()
19+
_ = try AES(key: key, blockMode: CBC(), padding: padding)
20+
_ = try AES(key: keyString, iv: ivString)
1821
_ = try Blowfish(key: key, blockMode: CBC(), padding: padding)
1922
_ = try Blowfish(key: keyString, iv: ivString)
2023

0 commit comments

Comments
 (0)