Skip to content

Commit bba3564

Browse files
authored
Swift: adjust for changes in main
1 parent 91b34d5 commit bba3564

File tree

4 files changed

+20
-17
lines changed

4 files changed

+20
-17
lines changed

swift/ql/lib/codeql/swift/dataflow/Ssa.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ module Ssa {
6161
AssignExpr a, BasicBlock bb, int i // TODO: use CFG node for assignment expr
6262
|
6363
this.definesAt(_, bb, i) and
64-
a = bb.getNode(i).getNode() and
65-
value.getNode() = a.getSource()
64+
a = bb.getNode(i).getNode().asAstNode() and
65+
value.getNode().asAstNode() = a.getSource()
6666
)
6767
}
6868
}

swift/ql/lib/codeql/swift/dataflow/internal/DataFlowPublic.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class ExprNode extends Node, TExprNode {
6060

6161
ExprNode() { this = TExprNode(expr) }
6262

63-
override Expr asExpr() { result = expr.getNode() }
63+
override Expr asExpr() { result = expr.getNode().asAstNode() }
6464

6565
override ControlFlowNode getCfgNode() { result = expr }
6666
}

swift/ql/lib/codeql/swift/dataflow/internal/SsaImplSpecific.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ class SourceVariable = VarDecl;
1616

1717
predicate variableWrite(BasicBlock bb, int i, SourceVariable v, boolean certain) {
1818
exists(AssignExpr assign |
19-
bb.getNode(i).getNode() = assign and
19+
bb.getNode(i).getNode().asAstNode() = assign and
2020
assign.getDest() = v.getAnAccess() and
2121
certain = true
2222
)
2323
or
2424
exists(PatternBindingDecl decl, Pattern pattern |
25-
bb.getNode(i).getNode() = pattern and
25+
bb.getNode(i).getNode().asAstNode() = pattern and
2626
decl.getAPattern() = pattern and
2727
v.getParentPattern() = pattern and
2828
certain = true
@@ -34,7 +34,7 @@ private predicate isLValue(DeclRefExpr ref) { any(AssignExpr assign).getDest() =
3434
predicate variableRead(BasicBlock bb, int i, SourceVariable v, boolean certain) {
3535
exists(DeclRefExpr ref |
3636
not isLValue(ref) and
37-
bb.getNode(i).getNode() = ref and
37+
bb.getNode(i).getNode().asAstNode() = ref and
3838
v = ref.getDecl() and
3939
certain = true
4040
)
Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
1-
| file://:0:0:0:0 | Phi | test.swift:15:15:15:15 | DeclRefExpr[VarDecl[var t2]] |
2-
| test.swift:6:9:6:13 | WriteDef | test.swift:7:15:7:15 | DeclRefExpr[VarDecl[var t1]] |
3-
| test.swift:7:15:7:15 | DeclRefExpr[VarDecl[var t1]] | test.swift:8:10:8:10 | DeclRefExpr[VarDecl[var t1]] |
4-
| test.swift:8:5:8:10 | WriteDef | test.swift:10:15:10:15 | DeclRefExpr[VarDecl[var t2]] |
5-
| test.swift:8:10:8:10 | DeclRefExpr[VarDecl[var t1]] | test.swift:8:5:8:10 | WriteDef |
6-
| test.swift:8:10:8:10 | DeclRefExpr[VarDecl[var t1]] | test.swift:9:15:9:15 | DeclRefExpr[VarDecl[var t1]] |
7-
| test.swift:9:15:9:15 | DeclRefExpr[VarDecl[var t1]] | test.swift:11:8:11:8 | DeclRefExpr[VarDecl[var t1]] |
8-
| test.swift:12:9:12:14 | WriteDef | test.swift:13:19:13:19 | DeclRefExpr[VarDecl[var t2]] |
9-
| test.swift:12:14:12:14 | IntegerLiteralExpr(0) | test.swift:12:9:12:14 | WriteDef |
10-
| test.swift:17:5:17:10 | WriteDef | test.swift:21:15:21:15 | DeclRefExpr[VarDecl[var t1]] |
11-
| test.swift:17:10:17:10 | IntegerLiteralExpr(0) | test.swift:17:5:17:10 | WriteDef |
1+
| file://:0:0:0:0 | Phi | test.swift:15:15:15:15 | DeclRefExpr |
2+
| file://:0:0:0:0 | Phi | test.swift:21:15:21:15 | DeclRefExpr |
3+
| test.swift:6:9:6:13 | WriteDef | test.swift:7:15:7:15 | DeclRefExpr |
4+
| test.swift:7:15:7:15 | DeclRefExpr | test.swift:8:10:8:10 | DeclRefExpr |
5+
| test.swift:8:5:8:10 | WriteDef | test.swift:10:15:10:15 | DeclRefExpr |
6+
| test.swift:8:10:8:10 | DeclRefExpr | test.swift:8:5:8:10 | WriteDef |
7+
| test.swift:8:10:8:10 | DeclRefExpr | test.swift:9:15:9:15 | DeclRefExpr |
8+
| test.swift:9:15:9:15 | DeclRefExpr | test.swift:11:8:11:8 | DeclRefExpr |
9+
| test.swift:12:9:12:14 | WriteDef | test.swift:13:19:13:19 | DeclRefExpr |
10+
| test.swift:12:14:12:14 | IntegerLiteralExpr | test.swift:12:9:12:14 | WriteDef |
11+
| test.swift:15:15:15:15 | DeclRefExpr | test.swift:19:14:19:14 | DeclRefExpr |
12+
| test.swift:17:10:17:10 | IntegerLiteralExpr | test.swift:17:5:17:10 | WriteDef |
13+
| test.swift:19:14:19:14 | DeclRefExpr | test.swift:19:9:19:14 | WriteDef |
14+
| test.swift:19:14:19:14 | DeclRefExpr | test.swift:19:14:19:14 | DeclRefExpr |

0 commit comments

Comments
 (0)