Skip to content

Commit bf2d7b3

Browse files
committed
Added IRestClientAsync methods to external location sink. Removed import from
Remote.qll, as it is un-necessary now.
1 parent 13997ca commit bf2d7b3

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

csharp/ql/src/semmle/code/csharp/frameworks/ServiceStack.qll

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,11 @@ module Sinks {
9191
exists(MethodCall mc |
9292
mc.getTarget().getQualifiedName() in [
9393
"ServiceStack.IRestClient.Get", "ServiceStack.IRestClient.Put",
94-
"ServiceStack.IRestClient.Post", "ServiceStack.IRestClient.Delete",
95-
"ServiceStack.IRestClient.Post", "ServiceStack.IRestClient.Put",
96-
"ServiceStack.IRestClient.Patch", "ServiceStack.IRestClient.Send"
94+
"ServiceStack.IRestClient.Post", "ServiceStack.IRestClient.Delete",
95+
"ServiceStack.IRestClient.Patch", "ServiceStack.IRestClient.Send",
96+
"ServiceStack.IRestClientAsync.GetAsync","ServiceStack.IRestClientAsync.DeleteAsync",
97+
"ServiceStack.IRestClientAsync.PutAsync","ServiceStack.IRestClientAsync.PostAsync",
98+
"ServiceStack.IRestClientAsync.PatchAsync","ServiceStack.IRestClientAsync.CustomMethodAsync"
9799
] and
98100
this.asExpr() = mc.getAnArgument()
99101
)

csharp/ql/src/semmle/code/csharp/security/dataflow/flowsinks/Remote.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ private import ExternalLocationSink
88
private import Html
99
private import semmle.code.csharp.security.dataflow.XSS
1010
private import semmle.code.csharp.frameworks.system.web.UI
11-
private import semmle.code.csharp.frameworks.ServiceStack::Sinks
1211

1312
/** A data flow sink of remote user output. */
1413
abstract class RemoteFlowSink extends DataFlow::Node { }

0 commit comments

Comments
 (0)